Skip to content

Commit 724bf31

Browse files
Trottcodebytere
authored andcommittedFeb 27, 2020
test: remove common.PORT from test-net-timeout
Switch test-net-timeout from common.PORT to a port assigned by the operating system. PR-URL: #31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 98d262e commit 724bf31

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed
 

‎test/pummel/test-net-timeout.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
const common = require('../common');
23+
require('../common');
2424
const assert = require('assert');
2525
const net = require('net');
2626

@@ -54,10 +54,11 @@ const echo_server = net.createServer((socket) => {
5454
});
5555
});
5656

57-
echo_server.listen(common.PORT, () => {
58-
console.log(`server listening at ${common.PORT}`);
57+
echo_server.listen(0, () => {
58+
const port = echo_server.address().port;
59+
console.log(`server listening at ${port}`);
5960

60-
const client = net.createConnection(common.PORT);
61+
const client = net.createConnection(port);
6162
client.setEncoding('UTF8');
6263
client.setTimeout(0); // Disable the timeout for client
6364
client.on('connect', () => {

0 commit comments

Comments
 (0)
Please sign in to comment.