Skip to content

Commit

Permalink
debugger: rename inspector-cli test module to debugger
Browse files Browse the repository at this point in the history
PR-URL: #38530
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Trott authored and targos committed Sep 4, 2021
1 parent e12164e commit 72a3419
Show file tree
Hide file tree
Showing 26 changed files with 53 additions and 53 deletions.
58 changes: 29 additions & 29 deletions test/common/README.md
Expand Up @@ -9,14 +9,14 @@ This directory contains modules used to test the Node.js implementation.
* [Common module API](#common-module-api)
* [Countdown module](#countdown-module)
* [CPU Profiler module](#cpu-profiler-module)
* [Debugger module](#debugger-module)
* [DNS module](#dns-module)
* [Duplex pair helper](#duplex-pair-helper)
* [Environment variables](#environment-variables)
* [Fixtures module](#fixtures-module)
* [Heap dump checker module](#heap-dump-checker-module)
* [hijackstdio module](#hijackstdio-module)
* [HTTP2 module](#http2-module)
* [Inspector CLI module](#inspector-cli-module)
* [Internet module](#internet-module)
* [ongc module](#ongc-module)
* [Report module](#report-module)
Expand Down Expand Up @@ -513,6 +513,34 @@ Sampling interval in microseconds.
Throws an `AssertionError` if there are no call frames with the expected
`suffix` in the profiling data contained in `file`.

## Debugger module

Provides common functionality for tests for `node inspect`.

### `startCLI(args[[, flags], spawnOpts])`

* `args` [&lt;string>][]
* `flags` [&lt;string>][] default = []
* `showOpts` [&lt;Object>][] default = {}
* return [&lt;Object>][]

Returns a null-prototype object with properties that are functions and getters
used to interact with the `node inspect` CLI. These functions are:

* `flushOutput()`
* `waitFor()`
* `waitForPrompt()`
* `waitForInitialBreak()`
* `breakInfo`
* `ctrlC()`
* `output`
* `rawOutput`
* `parseSourceLines()`
* `writeLine()`
* `command()`
* `stepCommand()`
* `quit()`

## `DNS` Module

The `DNS` module provides utilities related to the `dns` built-in module.
Expand Down Expand Up @@ -831,34 +859,6 @@ upon initial establishment of a connection.
socket.write(http2.kClientMagic);
```

## Inspector CLI module

Provides common functionality for tests for `node inspect`.

### `startCLI(args[[, flags], spawnOpts])`

* `args` [&lt;string>][]
* `flags` [&lt;string>][] default = []
* `showOpts` [&lt;Object>][] default = {}
* return [&lt;Object>][]

Returns a null-prototype object with properties that are functions and getters
used to interact with the `node inspect` CLI. These functions are:

* `flushOutput()`
* `waitFor()`
* `waitForPrompt()`
* `waitForInitialBreak()`
* `breakInfo`
* `ctrlC()`
* `output`
* `rawOutput`
* `parseSourceLines()`
* `writeLine()`
* `command()`
* `stepCommand()`
* `quit()`

## Internet Module

The `common/internet` module provides utilities for working with
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion test/parallel/test-debugger-address.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const { spawn } = require('child_process');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-auto-resume.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');
const { addLibraryPath } = require('../common/shared-lib-util');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-backtrace.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-break.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-clear-breakpoints.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-custom-port.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-exceptions.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-exec-scope.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-exec.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-heap-profiler.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');
const tmpdir = require('../common/tmpdir');
const path = require('path');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-help.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-invalid-args.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const { createServer } = require('net');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-launch.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-low-level.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');
const assert = require('assert');

// Debugger agent direct access.
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-pid.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const { spawn } = require('child_process');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-preserve-breaks.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-profile.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-random-port.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-run-after-quit-restart.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-sb-before-load.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');
const path = require('path');
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-scripts.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-use-strict.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-debugger-watchers.js
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/inspector-cli');
const startCLI = require('../common/debugger');

const assert = require('assert');

Expand Down

0 comments on commit 72a3419

Please sign in to comment.