From 766c2abff3574faab1d1f60d0664253348533218 Mon Sep 17 00:00:00 2001 From: Gabriel Schulhof Date: Thu, 26 Dec 2019 09:04:43 -0800 Subject: [PATCH] build: warn upon --use-largepages config option Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: https://github.com/nodejs/node/pull/31063#discussion_r361143460 Backport-PR-URL: https://github.com/nodejs/node/pull/31063 PR-URL: https://github.com/nodejs/node/pull/31103 Reviewed-By: Richard Lau Reviewed-By: Denys Otrishko --- configure.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/configure.py b/configure.py index 14787fe69155f3..dde68e041f464f 100755 --- a/configure.py +++ b/configure.py @@ -1040,6 +1040,13 @@ def configure_node(o): else: o['variables']['node_use_dtrace'] = 'false' + if options.node_use_large_pages or options.node_use_large_pages_script_lld: + warn('''The `--use-largepages` and `--use-largepages-script-lld` options + have no effect during build time. Support for mapping to large pages is + now a runtime option of Node.js. Run `node --use-largepages` or add + `--use-largepages` to the `NODE_OPTIONS` environment variable once + Node.js is built to enable mapping to large pages.''') + if options.no_ifaddrs: o['defines'] += ['SUNOS_NO_IFADDRS']