Skip to content

Commit 784df12

Browse files
mmarchiniMylesBorins
authored andcommittedApr 2, 2020
deps: revert whitespace changes on V8
While landing some of the V8 upgrades on the v12 branch, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. This was likely caused by the use of `git node land` or a simiar tool. Revert those changes to fix our tests. Since this only reverts unwanted changes on deps/v8, and it only affects tests, don't bump v8_embedder_string. PR-URL: #32605 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
1 parent f58594b commit 784df12

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed
 

‎deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorAccess.golden

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ snippet: "
1212
class A {
1313
get #a() { return 1; }
1414
set #a(val) { }
15-
15+
1616
constructor() {
1717
this.#a++;
1818
this.#a = 1;
@@ -189,3 +189,4 @@ constant pool: [
189189
]
190190
handlers: [
191191
]
192+

‎deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateAccessorDeclaration.golden

+2-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ snippet: "
165165
get #d() { return 1; }
166166
set #d(val) { }
167167
}
168-
168+
169169
class E extends D {
170170
get #e() { return 2; }
171171
set #e(val) { }
@@ -395,3 +395,4 @@ constant pool: [
395395
]
396396
handlers: [
397397
]
398+

‎deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodAccess.golden

+4-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ snippet: "
1313
#a() { return 1; }
1414
constructor() { return this.#a(); }
1515
}
16-
16+
1717
var test = A;
1818
new A;
1919
"
@@ -44,7 +44,7 @@ snippet: "
4444
#b() { return 1; }
4545
constructor() { this.#b = 1; }
4646
}
47-
47+
4848
var test = B;
4949
new test;
5050
"
@@ -76,7 +76,7 @@ snippet: "
7676
#c() { return 1; }
7777
constructor() { this.#c++; }
7878
}
79-
79+
8080
var test = C;
8181
new test;
8282
"
@@ -101,3 +101,4 @@ constant pool: [
101101
]
102102
handlers: [
103103
]
104+

‎deps/v8/test/cctest/interpreter/bytecode_expectations/PrivateMethodDeclaration.golden

+1
Original file line numberDiff line numberDiff line change
@@ -195,3 +195,4 @@ constant pool: [
195195
]
196196
handlers: [
197197
]
198+

0 commit comments

Comments
 (0)
Please sign in to comment.