From 7a794417f36fe35ea31698f88bc69214645a8e92 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 13 Jan 2021 04:56:03 -0800 Subject: [PATCH] doc: remove resolving-a-bug-report from contributing docs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This section isn't particularly useful in this context and contributes to making the document longer and less effective. This is part of a larger effort to make the contributing docs brief, informative, and friendly. Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560 PR-URL: https://github.com/nodejs/node/pull/36905 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Tobias Nießen --- CONTRIBUTING.md | 1 - doc/guides/contributing/issues.md | 9 --------- 2 files changed, 10 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d4ba35f6252271..c9f8b61cd14430 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,7 +19,6 @@ See [details on our policy on Code of Conduct](./doc/guides/contributing/code-of * [Discussing non-technical topics](./doc/guides/contributing/issues.md#discussing-non-technical-topics) * [Submitting a Bug Report](./doc/guides/contributing/issues.md#submitting-a-bug-report) * [Triaging a Bug Report](./doc/guides/contributing/issues.md#triaging-a-bug-report) -* [Resolving a Bug Report](./doc/guides/contributing/issues.md#resolving-a-bug-report) ## [Pull Requests](./doc/guides/contributing/pull-requests.md) diff --git a/doc/guides/contributing/issues.md b/doc/guides/contributing/issues.md index 9af1f37ff4c9da..b3786af7364e76 100644 --- a/doc/guides/contributing/issues.md +++ b/doc/guides/contributing/issues.md @@ -4,7 +4,6 @@ * [Discussing non-technical topics](#discussing-non-technical-topics) * [Submitting a Bug Report](#submitting-a-bug-report) * [Triaging a Bug Report](#triaging-a-bug-report) -* [Resolving a Bug Report](#resolving-a-bug-report) ## Asking for General Help @@ -88,13 +87,5 @@ activities, such as applying labels and closing/reopening/assigning issues. For more information on the roles and permissions, see ["Permission levels for repositories owned by an organization"](https://docs.github.com/en/github/setting-up-and-managing-organizations-and-teams/repository-permission-levels-for-an-organization#permission-levels-for-repositories-owned-by-an-organization). -## Resolving a Bug Report - -In the vast majority of cases, issues are resolved by opening a Pull Request. -The process for opening and reviewing a Pull Request is similar to that of -opening and triaging issues, but carries with it a necessary review and approval -workflow that ensures that the proposed changes meet the minimal quality and -functional guidelines of the Node.js project. - [Node.js help repository]: https://github.com/nodejs/help/issues [Technical Steering Committee (TSC) repository]: https://github.com/nodejs/TSC/issues