From 7a80312e191232ca64c9aefe4042ffb88c7aaae5 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 31 Mar 2023 22:47:16 +0200 Subject: [PATCH] src: don't reset embeder signal handlers The only bad handler value we can inhert from before exec is SIG_IGN (any actual function pointer is reset to SIG_DFL during exec). If that's the case, we want to reset it back to SIG_DFL. However, it's also possible that an embeder (or an LD_PRELOAD-ed library) has set up own signal handler for own purposes (e.g. profiling). If that's the case, keep it intact. Fix #47013 PR-URL: https://github.com/nodejs/node/pull/47188 Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell --- src/node.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/node.cc b/src/node.cc index 6bdcbb3de9064b..924584477dd2a0 100644 --- a/src/node.cc +++ b/src/node.cc @@ -447,6 +447,17 @@ void ResetSignalHandlers() { if (nr == SIGKILL || nr == SIGSTOP) continue; act.sa_handler = (nr == SIGPIPE || nr == SIGXFSZ) ? SIG_IGN : SIG_DFL; + if (act.sa_handler == SIG_DFL) { + // The only bad handler value we can inhert from before exec is SIG_IGN + // (any actual function pointer is reset to SIG_DFL during exec). + // If that's the case, we want to reset it back to SIG_DFL. + // However, it's also possible that an embeder (or an LD_PRELOAD-ed + // library) has set up own signal handler for own purposes + // (e.g. profiling). If that's the case, we want to keep it intact. + struct sigaction old; + CHECK_EQ(0, sigaction(nr, nullptr, &old)); + if ((old.sa_flags & SA_SIGINFO) || old.sa_handler != SIG_IGN) continue; + } CHECK_EQ(0, sigaction(nr, &act, nullptr)); } #endif // __POSIX__