Skip to content

Commit 7aa2ee2

Browse files
addaleaxtargos
authored andcommittedApr 22, 2020
src: delete CallbackInfo when cleared from cleanup hook
Fixes: #32400 PR-URL: #32405 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 97e352d commit 7aa2ee2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/node_buffer.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,14 @@ void CallbackInfo::WeakCallback(
162162
const WeakCallbackInfo<CallbackInfo>& data) {
163163
CallbackInfo* self = data.GetParameter();
164164
self->WeakCallback(data.GetIsolate());
165-
delete self;
166165
}
167166

168167

169168
void CallbackInfo::WeakCallback(Isolate* isolate) {
170169
callback_(data_, hint_);
171170
int64_t change_in_bytes = -static_cast<int64_t>(sizeof(*this));
172171
isolate->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
172+
delete this;
173173
}
174174

175175

0 commit comments

Comments
 (0)
Please sign in to comment.