From 7b8380dd737bba520441f039ec08d11493d75ba7 Mon Sep 17 00:00:00 2001 From: Santiago Gimeno Date: Thu, 27 Oct 2022 19:13:50 +0200 Subject: [PATCH] test: use uv_sleep() where possible MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/45124 Reviewed-By: Michaël Zasso Reviewed-By: Darshan Sen Reviewed-By: theanarkh Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Daeyeon Jeong Reviewed-By: Juan José Arboleda Reviewed-By: Gerhard Stöbich --- test/addons/async-hello-world/binding.cc | 13 +------------ test/node-api/test_async/test_async.c | 19 +++---------------- 2 files changed, 4 insertions(+), 28 deletions(-) diff --git a/test/addons/async-hello-world/binding.cc b/test/addons/async-hello-world/binding.cc index 2f77aee52ab2d9..1d8a4d791cf276 100644 --- a/test/addons/async-hello-world/binding.cc +++ b/test/addons/async-hello-world/binding.cc @@ -2,13 +2,6 @@ #include #include -#if defined _WIN32 -#include -#else -#include -#endif - - struct async_req { uv_work_t req; int input; @@ -21,11 +14,7 @@ struct async_req { void DoAsync(uv_work_t* r) { async_req* req = reinterpret_cast(r->data); // Simulate CPU intensive process... -#if defined _WIN32 - Sleep(1000); -#else - sleep(1); -#endif + uv_sleep(1000); req->output = req->input * 2; } diff --git a/test/node-api/test_async/test_async.c b/test/node-api/test_async/test_async.c index 650cf2d6241643..f4faa3d81b0326 100644 --- a/test/node-api/test_async/test_async.c +++ b/test/node-api/test_async/test_async.c @@ -1,14 +1,9 @@ #include #include #include +#include #include "../../js-native-api/common.h" -#if defined _WIN32 -#include -#else -#include -#endif - // this needs to be greater than the thread pool size #define MAX_CANCEL_THREADS 6 @@ -23,11 +18,7 @@ static carrier the_carrier; static carrier async_carrier[MAX_CANCEL_THREADS]; static void Execute(napi_env env, void* data) { -#if defined _WIN32 - Sleep(1000); -#else - sleep(1); -#endif + uv_sleep(1000); carrier* c = (carrier*)(data); assert(c == &the_carrier); @@ -130,11 +121,7 @@ static void CancelComplete(napi_env env, napi_status status, void* data) { } static void CancelExecute(napi_env env, void* data) { -#if defined _WIN32 - Sleep(1000); -#else - sleep(1); -#endif + uv_sleep(1000); } static napi_value TestCancel(napi_env env, napi_callback_info info) {