From 7ba8ae4cf19c43659e90c0e1040c238f17e75586 Mon Sep 17 00:00:00 2001 From: Gabriel Schulhof Date: Mon, 27 Aug 2018 16:59:56 -0400 Subject: [PATCH] squash! address review comments --- doc/api/n-api.md | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/doc/api/n-api.md b/doc/api/n-api.md index f7bb07685d2ed4..fd3b56e2b04e8a 100644 --- a/doc/api/n-api.md +++ b/doc/api/n-api.md @@ -46,17 +46,14 @@ example is: [node-addon-api](https://github.com/nodejs/node-addon-api). Although N-API provides an ABI stability guarantee, other parts of Node.js do not, and any external libraries used from the addon may not. In particular, -neither of the following Node.js APIs provides an ABI stability guarantee: +none of the following APIs provide an ABI stability guarantee across major +versions: * the Node.js C++ APIs available via any of ```C++ + #include #include - #include - #include - #include - #include - #include - #include #include + #include ``` * the libuv APIs which are also included with Node.js and available via ```C++ @@ -72,7 +69,7 @@ must make use exclusively of N-API by restricting itself to using ```C #include ``` -and by checking, for all external library that it uses, that the external +and by checking, for all external libraries that it uses, that the external library makes ABI stability guarantees similar to N-API. ## Usage