perf_hooks: do not return all entries with getEntriesBy[Name|Type]

Fix: #42028 PR-URL: #42104 Fixes: #42028 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs · Apr 24, 2022 · 7c0b8ca · 7c0b8ca
1 parent 1a0f26f
commit 7c0b8ca
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/lib/internal/perf/performance.js b/lib/internal/perf/performance.js
@@ -9,6 +9,7 @@ const {
 const {
   codes: {
     ERR_ILLEGAL_CONSTRUCTOR,
+    ERR_MISSING_ARGS
   }
 } = require('internal/errors');
 
@@ -86,16 +87,18 @@ function getEntries() {
 }
 
 function getEntriesByName(name) {
-  if (name !== undefined) {
-    name = `${name}`;
+  if (arguments.length === 0) {
+    throw new ERR_MISSING_ARGS('name');
   }
+  name = `${name}`;
   return filterBufferMapByNameAndType(name, undefined);
 }
 
 function getEntriesByType(type) {
-  if (type !== undefined) {
-    type = `${type}`;
+  if (arguments.length === 0) {
+    throw new ERR_MISSING_ARGS('type');
   }
+  type = `${type}`;
   return filterBufferMapByNameAndType(undefined, type);
 }
 

diff --git a/test/parallel/test-performance-timeline.mjs b/test/parallel/test-performance-timeline.mjs
@@ -33,3 +33,18 @@ await setTimeout(50);
 performance.measure('a', 'one');
 const entriesByName = performance.getEntriesByName('a');
 assert.deepStrictEqual(entriesByName.map((x) => x.entryType), ['measure', 'mark', 'measure', 'mark']);
+
+// getEntriesBy[Name|Type](undefined)
+performance.mark(undefined);
+assert.strictEqual(performance.getEntriesByName(undefined).length, 1);
+assert.strictEqual(performance.getEntriesByType(undefined).length, 0);
+assert.throws(() => performance.getEntriesByName(), {
+  name: 'TypeError',
+  message: 'The "name" argument must be specified',
+  code: 'ERR_MISSING_ARGS'
+});
+assert.throws(() => performance.getEntriesByType(), {
+  name: 'TypeError',
+  message: 'The "type" argument must be specified',
+  code: 'ERR_MISSING_ARGS'
+});