From 7d058a4c014461a42d39f5bb96c25e5487049b67 Mon Sep 17 00:00:00 2001 From: Ruy Adorno Date: Wed, 15 Jul 2020 10:55:28 -0400 Subject: [PATCH] doc: add author-ready label ref to onboarding doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: https://github.com/nodejs/node/pull/34381 Reviewed-By: Richard Lau Reviewed-By: Anna Henningsen Reviewed-By: Trivikram Kamat Reviewed-By: Gireesh Punathil Reviewed-By: Juan José Arboleda Reviewed-By: Gerhard Stöbich Reviewed-By: Myles Borins --- doc/guides/onboarding-extras.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/guides/onboarding-extras.md b/doc/guides/onboarding-extras.md index 91ed05d9d3658e..de7d230217b681 100644 --- a/doc/guides/onboarding-extras.md +++ b/doc/guides/onboarding-extras.md @@ -24,7 +24,19 @@ request. * `tsc-agenda` - Open issues and pull requests with this label will be added to the Technical Steering Committee meeting agenda --- +--- + +* `author-ready` - A pull request is _author ready_ when: + * There is a CI run in progress or completed. + * There is at least one Collaborator approval (or two TSC approvals + for semver-major PRs). + * There are no outstanding review comments. + +Please always add the `author ready` label to the pull request in that case. +Please always remove it again as soon as the conditions are not met anymore, +such as if CI run fails or a new outstanding review comment is posted. + +--- * `semver-{minor,major}` * be conservative – that is, if a change has the remote *chance* of breaking