diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js index a2a6452a3fcf60..8f0657c8d5b193 100644 --- a/lib/internal/event_target.js +++ b/lib/internal/event_target.js @@ -201,7 +201,8 @@ function initEventTarget(self) { class EventTarget { // Used in checking whether an object is an EventTarget. This is a well-known - // symbol as EventTarget may be used cross-realm. See discussion in #33661. + // symbol as EventTarget may be used cross-realm. + // Ref: https://github.com/nodejs/node/pull/33661 static [kIsEventTarget] = true; constructor() { @@ -520,8 +521,8 @@ function validateEventListenerOptions(options) { // Test whether the argument is an event object. This is far from a fool-proof // test, for example this input will result in a false positive: // > isEventTarget({ constructor: EventTarget }) -// It stands in its current implementation as a compromise. For the relevant -// discussion, see #33661. +// It stands in its current implementation as a compromise. +// Ref: https://github.com/nodejs/node/pull/33661 function isEventTarget(obj) { return obj && obj.constructor && obj.constructor[kIsEventTarget]; } diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js index 233741285d2c72..4f48c2be794626 100644 --- a/lib/internal/stream_base_commons.js +++ b/lib/internal/stream_base_commons.js @@ -204,7 +204,8 @@ function onStreamRead(arrayBuffer) { } if (nread !== UV_EOF) { - // #34375 CallJSOnreadMethod expects the return value to be a buffer. + // CallJSOnreadMethod expects the return value to be a buffer. + // Ref: https://github.com/nodejs/node/pull/34375 stream.destroy(errnoException(nread, 'read')); return; } @@ -224,7 +225,8 @@ function onStreamRead(arrayBuffer) { if (handle.readStop) { const err = handle.readStop(); if (err) { - // #34375 CallJSOnreadMethod expects the return value to be a buffer. + // CallJSOnreadMethod expects the return value to be a buffer. + // Ref: https://github.com/nodejs/node/pull/34375 stream.destroy(errnoException(err, 'read')); return; }