Skip to content

Commit 80493f5

Browse files
watsontargos
authored andcommittedApr 22, 2020
doc: fix some 404 links
PR-URL: #32200 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 8dbd7cf commit 80493f5

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed
 

‎doc/guides/contributing/pull-requests.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ included in the API docs will also be checked when running `make lint` (or
121121
use `REPLACEME` for the version number in the documentation YAML.
122122

123123
For contributing C++ code, you may want to look at the
124-
[C++ Style Guide](../../cpp-style-guide.md), as well as the
124+
[C++ Style Guide](../cpp-style-guide.md), as well as the
125125
[README of `src/`](../../../src/README.md) for an overview over Node.js
126126
C++ internals.
127127

@@ -582,14 +582,14 @@ If you want to know more about the code review and the landing process, see the
582582
[Collaborator Guide][].
583583

584584
[approved]: #getting-approvals-for-your-pull-request
585-
[benchmark results]: ../../../benchmark/writing-and-running-benchmarks.md
585+
[benchmark results]: ../writing-and-running-benchmarks.md
586586
[Building guide]: ../../../BUILDING.md
587587
[CI (Continuous Integration) test run]: #ci-testing
588588
[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
589-
[Collaborator Guide]: ../../../COLLABORATOR_GUIDE.md
589+
[Collaborator Guide]: ../collaborator-guide.md
590590
[guide for writing tests in Node.js]: ../writing-tests.md
591591
[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
592592
[https://ci.nodejs.org/]: https://ci.nodejs.org/
593593
[IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4
594-
[Onboarding guide]: ../../onboarding.md
594+
[Onboarding guide]: ../../../onboarding.md
595595
[running tests]: ../../../BUILDING.md#running-tests

‎onboarding.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -239,13 +239,13 @@ needs to be pointed out separately during the onboarding.
239239
the [summit](https://github.com/nodejs/summit) repository for details.
240240

241241
[Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
242-
[`author-ready`]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#author-ready-pull-requests
242+
[`author-ready`]: doc/guides/collaborator-guide.md#author-ready-pull-requests
243243
[`core-validate-commit`]: https://github.com/nodejs/core-validate-commit
244244
[`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
245245
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
246-
[Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests
246+
[Landing Pull Requests]: doc/guides/collaborator-guide.md#landing-pull-requests
247247
[Publicizing or hiding organization membership]: https://help.github.com/articles/publicizing-or-hiding-organization-membership/
248248
[set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
249249
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/
250250
[using a TOTP mobile app]: https://help.github.com/articles/configuring-two-factor-authentication-via-a-totp-mobile-app/
251-
[who-to-cc]: ../COLLABORATOR_GUIDE.md#who-to-cc-in-the-issue-tracker
251+
[who-to-cc]: doc/guides/collaborator-guide.md#who-to-cc-in-the-issue-tracker

0 commit comments

Comments
 (0)
Please sign in to comment.