Skip to content

Commit 806a269

Browse files
SimenBBethGriggs
authored andcommittedDec 15, 2020
doc: importModuleDynamically gets Script, not Module
PR-URL: #35593 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent f535d62 commit 806a269

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed
 

‎doc/api/vm.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ changes:
9090
This option is part of the experimental modules API, and should not be
9191
considered stable.
9292
* `specifier` {string} specifier passed to `import()`
93-
* `module` {vm.Module}
93+
* `script` {vm.Script}
9494
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
9595
recommended in order to take advantage of error tracking, and to avoid
9696
issues with namespaces that contain `then` function exports.
@@ -982,7 +982,7 @@ changes:
982982
This option is part of the experimental modules API, and should not be
983983
considered stable.
984984
* `specifier` {string} specifier passed to `import()`
985-
* `module` {vm.Module}
985+
* `script` {vm.Script}
986986
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
987987
recommended in order to take advantage of error tracking, and to avoid
988988
issues with namespaces that contain `then` function exports.
@@ -1080,7 +1080,7 @@ changes:
10801080
This option is part of the experimental modules API, and should not be
10811081
considered stable.
10821082
* `specifier` {string} specifier passed to `import()`
1083-
* `module` {vm.Module}
1083+
* `script` {vm.Script}
10841084
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
10851085
recommended in order to take advantage of error tracking, and to avoid
10861086
issues with namespaces that contain `then` function exports.
@@ -1159,7 +1159,7 @@ changes:
11591159
This option is part of the experimental modules API, and should not be
11601160
considered stable.
11611161
* `specifier` {string} specifier passed to `import()`
1162-
* `module` {vm.Module}
1162+
* `script` {vm.Script}
11631163
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
11641164
recommended in order to take advantage of error tracking, and to avoid
11651165
issues with namespaces that contain `then` function exports.

‎tools/doc/type-parser.js

+1
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ const customTypesMap = {
160160
'URLSearchParams': 'url.html#url_class_urlsearchparams',
161161

162162
'vm.Module': 'vm.html#vm_class_vm_module',
163+
'vm.Script': 'vm.html#vm_class_vm_script',
163164
'vm.SourceTextModule': 'vm.html#vm_class_vm_sourcetextmodule',
164165

165166
'MessagePort': 'worker_threads.html#worker_threads_class_messageport',

0 commit comments

Comments
 (0)