Skip to content

Commit 807b68b

Browse files
RaisinTentargos
authored andcommittedOct 4, 2021
deps: V8: cherry-pick 00bb1a77c03e
Original commit message: [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by: Darshan Sen <raisinten@gmail.com> Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76367} Refs: v8/v8@00bb1a7 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39829 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent be01694 commit 807b68b

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.7',
39+
'v8_embedder_string': '-node.8',
4040

4141
##### V8 defaults for Node.js #####
4242

‎deps/v8/AUTHORS

+1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ Daniel Andersson <kodandersson@gmail.com>
8686
Daniel Bevenius <daniel.bevenius@gmail.com>
8787
Daniel Dromboski <dandromb@gmail.com>
8888
Daniel James <dnljms@gmail.com>
89+
Darshan Sen <raisinten@gmail.com>
8990
David Carlier <devnexen@gmail.com>
9091
David Manouchehri <david@davidmanouchehri.com>
9192
Deepak Mohan <hop2deep@gmail.com>

‎deps/v8/test/mjsunit/regress/regress-crbug-422858.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@
33
// found in the LICENSE file.
44

55
var date = new Date("2016/01/02 10:00 GMT-8")
6-
assertEquals(0, date.getMinutes());
6+
assertEquals(0, date.getUTCMinutes());
77
assertEquals(18, date.getUTCHours());
88

99
date = new Date("2016/01/02 10:00 GMT-12")
10-
assertEquals(0, date.getMinutes());
10+
assertEquals(0, date.getUTCMinutes());
1111
assertEquals(22, date.getUTCHours());
1212

1313
date = new Date("2016/01/02 10:00 GMT-123")
14-
assertEquals(23, date.getMinutes());
14+
assertEquals(23, date.getUTCMinutes());
1515
assertEquals(11, date.getUTCHours());
1616

1717
date = new Date("2016/01/02 10:00 GMT-0856")
18-
assertEquals(56, date.getMinutes());
18+
assertEquals(56, date.getUTCMinutes());
1919
assertEquals(18, date.getUTCHours());
2020

2121
date = new Date("2016/01/02 10:00 GMT-08000")
22-
assertEquals(NaN, date.getMinutes());
22+
assertEquals(NaN, date.getUTCMinutes());
2323
assertEquals(NaN, date.getUTCHours());

0 commit comments

Comments
 (0)
Please sign in to comment.