From 8212eabd80f1f684643b99b6a4b289ed2cef1f5a Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 19 Nov 2022 11:47:25 -0800 Subject: [PATCH] test: revise pull request guide text about code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: https://github.com/nodejs/node/issues/45502 PR-URL: https://github.com/nodejs/node/pull/45519 Reviewed-By: Chengzhong Wu Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen --- doc/contributing/pull-requests.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index cf130d0d2e5391..33715bc3c2096e 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -107,13 +107,13 @@ git checkout -b my-branch -t upstream/HEAD ### Step 3: Code -The vast majority of pull requests opened against the `nodejs/node` -repository includes changes to one or more of the following: +Pull requests in Node.js typically involve changes to +one or more of a few places in the repository. -* the C/C++ code contained in the `src` directory -* the JavaScript code contained in the `lib` directory -* the documentation in `doc/api` -* tests within the `test` directory. +* C/C++ code contained in the `src` directory +* JavaScript code contained in the `lib` directory +* Documentation in `doc/api` +* Tests within the `test` directory If you are modifying code, please be sure to run `make lint` (or `vcbuild.bat lint` on Windows) to ensure that the changes follow the Node.js