From 83ad272fa601c5e7209989b04bedb4f67d54279b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tobias=20Nie=C3=9Fen?= Date: Sun, 19 Nov 2023 14:15:35 +0000 Subject: [PATCH] src: remove erroneous default argument in RadixTree MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This default argument can never benefit any potential caller because any call site that occurs after this definition will result in a compiler error due to RadixTree::Lookup(const std::string_view&) now being an ambiguous call target. PR-URL: https://github.com/nodejs/node/pull/50736 Reviewed-By: Rafael Gonzaga Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Luigi Pinca --- src/permission/fs_permission.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc index 042dc0ff297216..9f8ab281618418 100644 --- a/src/permission/fs_permission.cc +++ b/src/permission/fs_permission.cc @@ -172,7 +172,7 @@ FSPermission::RadixTree::~RadixTree() { } bool FSPermission::RadixTree::Lookup(const std::string_view& s, - bool when_empty_return = false) const { + bool when_empty_return) const { FSPermission::RadixTree::Node* current_node = root_node_; if (current_node->children.size() == 0) { return when_empty_return;