From 85d152fccf9fbf1a60f59bd67e1a9daf3664fd1b Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Fri, 27 Dec 2019 18:12:19 +0100 Subject: [PATCH] tools: allow the travis commit message job to fail Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: https://github.com/nodejs/node/pull/31116 Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: David Carlier Reviewed-By: Yongsheng Zhang Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 77694bddf3b05e..de7d7d47f88681 100644 --- a/.travis.yml +++ b/.travis.yml @@ -85,3 +85,4 @@ jobs: - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics allow_failures: # TODO (cclauss): remove this when dependencies are clean - name: "Find syntax errors in our Python dependencies" + - name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q"