From 875de23ee969510ba5b8e15ce5a0d70ffd01ae87 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Sat, 15 Oct 2022 18:27:24 -0300 Subject: [PATCH] doc: improve the workflow to test release binaries PR-URL: https://github.com/nodejs/node/pull/45004 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- doc/contributing/releases.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index a1045476d18399..4e7ac323d233e6 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -603,13 +603,14 @@ the build before moving forward. Use the following list as a baseline: must be in the expected updated version) * npm version (check it matches what we expect) * Run the test suite against the built binaries (optional) + * Remember to use the proposal branch + * Run `make build-addons` before running the tests + * Remove `config.gypi` file ```console ./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node ``` -There may be test issues if the branch used to test does not match the Node.js binary. - ### 11. Tag and sign the release commit Once you have produced builds that you're happy with, create a new tag. By