Skip to content

Commit 8a0b0a7

Browse files
targoscodebytere
authored andcommittedMar 30, 2020
build: enable backtrace when V8 is built for PPC and S390x
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 256bc44 commit 8a0b0a7

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
 

‎common.gypi

+3
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@
136136
['OS=="mac"', {
137137
'clang%': 1,
138138
}],
139+
['target_arch in "ppc64 s390x"', {
140+
'v8_enable_backtrace': 1,
141+
}],
139142
],
140143
},
141144

‎tools/make-v8.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ if [[ "$ARCH" == "s390x" ]] || [[ "$ARCH" == "ppc64le" ]]; then
2828
g++ --version
2929
gcc --version
3030
export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config
31-
gn gen -v out.gn/$BUILD_ARCH_TYPE --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\""
31+
gn gen -v out.gn/$BUILD_ARCH_TYPE --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true"
3232
ninja -v -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test
3333
else
3434
PATH=~/_depot_tools:$PATH tools/dev/v8gen.py $BUILD_ARCH_TYPE --no-goma $V8_BUILD_OPTIONS

0 commit comments

Comments
 (0)
Please sign in to comment.