From 8aad81dd996231a65f2b4bdb54934d0e785c5cda Mon Sep 17 00:00:00 2001 From: FrankQiu Date: Fri, 3 Sep 2021 23:33:15 +0800 Subject: [PATCH] doc: add full list of subsystems PR-URL: https://github.com/nodejs/node/pull/39971 Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Qingyu Deng --- doc/guides/contributing/pull-requests.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 763b05491592d1..29c0554d35fd7f 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -579,6 +579,8 @@ If you want to know more about the code review and the landing process, see the * `test` * `tools` +You can find the full list of supported subsystems in the +[nodejs/core-validate-commit][] repository. More than one subsystem may be valid for any particular issue or pull request. [Building guide]: ../../../BUILDING.md @@ -591,5 +593,6 @@ More than one subsystem may be valid for any particular issue or pull request. [guide for writing tests in Node.js]: ../writing-tests.md [hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment [https://ci.nodejs.org/]: https://ci.nodejs.org/ +[nodejs/core-validate-commit]: https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js [pull request template]: https://raw.githubusercontent.com/nodejs/node/HEAD/.github/PULL_REQUEST_TEMPLATE.md [running tests]: ../../../BUILDING.md#running-tests