From 90f4e163506b7f7f252fb19906fc9579a78cb2d2 Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Tue, 14 Mar 2023 20:20:22 -0700 Subject: [PATCH] src: fix clang 14 linker error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Compiling with clang 14 on Ubuntu was failing with a linker error that `node::MaybeStackBuffer::AllocateSufficientStorage` was undefined in `src/inspector/node_string.cc`. I bisected it to the referenced PR. Include `util-inl.h` which defines `node::MaybeStackBuffer::AllocateSufficientStorage`. Refs: https://github.com/nodejs/node/pull/46817 PR-URL: https://github.com/nodejs/node/pull/47057 Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen --- src/inspector/node_string.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/inspector/node_string.cc b/src/inspector/node_string.cc index 441d9a352eaca8..171ba04bef113b 100644 --- a/src/inspector/node_string.cc +++ b/src/inspector/node_string.cc @@ -2,6 +2,7 @@ #include "node/inspector/protocol/Protocol.h" #include "node_util.h" #include "simdutf.h" +#include "util-inl.h" namespace node { namespace inspector {