Skip to content

Commit 929e8df

Browse files
pd4d10danielleadams
authored andcommittedMay 31, 2021
test: improve coverage of stream.Readable
PR-URL: #38702 Refs: https://coverage.nodejs.org/coverage-0996eb71edbd47d9/lib/internal/streams/readable.js.html#L401 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent bad4d44 commit 929e8df

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed
 

‎test/parallel/test-streams-highwatermark.js

+13
Original file line numberDiff line numberDiff line change
@@ -57,3 +57,16 @@ const { inspect } = require('util');
5757
readable._read = common.mustCall();
5858
readable.read(0);
5959
}
60+
61+
{
62+
// Parse size as decimal integer
63+
['1', '1.0', 1].forEach((size) => {
64+
const readable = new stream.Readable({
65+
read: common.mustCall(),
66+
highWaterMark: 0,
67+
});
68+
readable.read(size);
69+
70+
assert.strictEqual(readable._readableState.highWaterMark, Number(size));
71+
});
72+
}

0 commit comments

Comments
 (0)
Please sign in to comment.