Skip to content

Commit 930647d

Browse files
sam-githubBethGriggs
authored andcommittedSep 19, 2019
test: skip tests related to CI failures on AIX
These tests seem to trigger failures in the entire CI job (not just the test) on AIX. Skip them to see if that helps alleviate spurious failures in node-test-commit-aix (and the upstream PR and commit test jobs). See: - nodejs/build#1820 (comment) - nodejs/build#1847 (comment) PR-URL: #28469 Backport-PR-URL: #29599 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 7bef222 commit 930647d

File tree

4 files changed

+15
-0
lines changed

4 files changed

+15
-0
lines changed
 

‎test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js

+5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements';
55
if (!common.enoughTestMem)
66
common.skip(skipMessage);
77

8+
// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
9+
// See https://github.com/nodejs/node/pull/28469
10+
if (process.platform === 'aix')
11+
common.skip('flaky on AIX');
12+
813
const binding = require(`./build/${common.buildType}/binding`);
914
const assert = require('assert');
1015

‎test/message/message.status

+3
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,6 @@ prefix message
1616

1717
[$system==freebsd]
1818

19+
[$system==aix]
20+
# https://github.com/nodejs/node/pull/28469
21+
vm_dont_display_syntax_error: SKIP

‎test/pseudo-tty/pseudo-tty.status

+4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ prefix pseudo-tty
33
[$system==aix]
44
# being investigated under https://github.com/nodejs/node/issues/9728
55
test-tty-wrap : FAIL, PASS
6+
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
7+
# https://github.com/nodejs/node/pull/28469
8+
console-dumb-tty: SKIP
9+
test-fatal-error: SKIP
610

711
[$system==solaris]
812
# https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems

‎test/sequential/sequential.status

+3
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,6 @@ test-http2-settings-flood: PASS,FLAKY
2525
[$system==freebsd]
2626

2727
[$system==aix]
28+
# https://github.com/nodejs/node/pull/28469
29+
test-async-wrap-getasyncid: SKIP
30+
test-buffer-creation-regression: SKIP

0 commit comments

Comments
 (0)
Please sign in to comment.