build: fix warning in cares under GN build

zcbenz · richardlau · commit 93fcf5299072 · 2024-03-25T19:27:08.000Z
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/deps/cares/unofficial.gni b/deps/cares/unofficial.gni
@@ -69,6 +69,8 @@ template("cares_gn_build") {
       cflags_c = [
         "-Wno-implicit-fallthrough",
         "-Wno-unreachable-code",
+        # Remove after https://github.com/c-ares/c-ares/pull/709 lands in Node.
+        "-Wno-unused-result",
       ]
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,8 @@ template("cares_gn_build") {`
`69`	`69`	`cflags_c = [`
`70`	`70`	`"-Wno-implicit-fallthrough",`
`71`	`71`	`"-Wno-unreachable-code",`
	`72`	`+ # Remove after https://github.com/c-ares/c-ares/pull/709 lands in Node.`
	`73`	`+ "-Wno-unused-result",`
`72`	`74`	`]`
`73`	`75`	`}`
`74`	`76`	`}`