From 94dd7b9f94fd151195820e961de997a0ad7ca40a Mon Sep 17 00:00:00 2001 From: Kim-Anh Tran Date: Thu, 18 Jun 2020 08:40:30 +0200 Subject: [PATCH] test: update tests after increasing typed array size to 4GB PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By: Rich Trott Reviewed-By: Jiawen Geng Reviewed-By: Daniel Bevenius Reviewed-By: Matteo Collina Reviewed-By: Myles Borins --- test/parallel/test-buffer-alloc.js | 5 +++-- test/parallel/test-buffer-over-max-length.js | 13 +++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js index 070a3803802e56..c72e286f3f0e2c 100644 --- a/test/parallel/test-buffer-alloc.js +++ b/test/parallel/test-buffer-alloc.js @@ -1,5 +1,6 @@ 'use strict'; const common = require('../common'); + const assert = require('assert'); const vm = require('vm'); @@ -8,8 +9,8 @@ const SlowBuffer = require('buffer').SlowBuffer; // Verify the maximum Uint8Array size. There is no concrete limit by spec. The // internal limits should be updated if this fails. assert.throws( - () => new Uint8Array(2 ** 32), - { message: 'Invalid typed array length: 4294967296' } + () => new Uint8Array(2 ** 32 + 1), + { message: 'Invalid typed array length: 4294967297' } ); const b = Buffer.allocUnsafe(1024); diff --git a/test/parallel/test-buffer-over-max-length.js b/test/parallel/test-buffer-over-max-length.js index f02c4d1ddd35cd..c263633d941cdd 100644 --- a/test/parallel/test-buffer-over-max-length.js +++ b/test/parallel/test-buffer-over-max-length.js @@ -1,5 +1,6 @@ 'use strict'; require('../common'); + const assert = require('assert'); const buffer = require('buffer'); @@ -12,11 +13,11 @@ const bufferMaxSizeMsg = { message: /^The argument 'size' is invalid\. Received [^"]*$/ }; -assert.throws(() => Buffer((-1 >>> 0) + 1), bufferMaxSizeMsg); -assert.throws(() => SlowBuffer((-1 >>> 0) + 1), bufferMaxSizeMsg); -assert.throws(() => Buffer.alloc((-1 >>> 0) + 1), bufferMaxSizeMsg); -assert.throws(() => Buffer.allocUnsafe((-1 >>> 0) + 1), bufferMaxSizeMsg); -assert.throws(() => Buffer.allocUnsafeSlow((-1 >>> 0) + 1), bufferMaxSizeMsg); +assert.throws(() => Buffer((-1 >>> 0) + 2), bufferMaxSizeMsg); +assert.throws(() => SlowBuffer((-1 >>> 0) + 2), bufferMaxSizeMsg); +assert.throws(() => Buffer.alloc((-1 >>> 0) + 2), bufferMaxSizeMsg); +assert.throws(() => Buffer.allocUnsafe((-1 >>> 0) + 2), bufferMaxSizeMsg); +assert.throws(() => Buffer.allocUnsafeSlow((-1 >>> 0) + 2), bufferMaxSizeMsg); assert.throws(() => Buffer(kMaxLength + 1), bufferMaxSizeMsg); assert.throws(() => SlowBuffer(kMaxLength + 1), bufferMaxSizeMsg); @@ -25,5 +26,5 @@ assert.throws(() => Buffer.allocUnsafe(kMaxLength + 1), bufferMaxSizeMsg); assert.throws(() => Buffer.allocUnsafeSlow(kMaxLength + 1), bufferMaxSizeMsg); // issue GH-4331 -assert.throws(() => Buffer.allocUnsafe(0x100000000), bufferMaxSizeMsg); +assert.throws(() => Buffer.allocUnsafe(0x100000001), bufferMaxSizeMsg); assert.throws(() => Buffer.allocUnsafe(0xFFFFFFFFF), bufferMaxSizeMsg);