diff --git a/src/node_snapshot_builder.h b/src/node_snapshot_builder.h index 7a82c00255e780..ce99dfdd6632b3 100644 --- a/src/node_snapshot_builder.h +++ b/src/node_snapshot_builder.h @@ -31,8 +31,6 @@ class NODE_EXTERN_PRIVATE SnapshotBuilder { v8::Isolate::CreateParams* params); private: - // Used to synchronize access to the snapshot data - static Mutex snapshot_data_mutex_; static const std::vector& CollectExternalReferences(); static std::unique_ptr registry_; diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc index cb42a464c2ac0a..b1806ce86630b9 100644 --- a/src/node_snapshotable.cc +++ b/src/node_snapshotable.cc @@ -978,7 +978,7 @@ static void WriteCodeCacheInitializer(std::ostream* ss, const std::string& id) { *ss << " },\n"; } -void FormatBlob(std::ostream& ss, SnapshotData* data) { +void FormatBlob(std::ostream& ss, const SnapshotData* data) { ss << R"(#include #include "env.h" #include "node_snapshot_builder.h" @@ -1004,7 +1004,7 @@ static const int v8_snapshot_blob_size = )" WriteStaticCodeCacheData(&ss, item); } - ss << R"(SnapshotData snapshot_data { + ss << R"(const SnapshotData snapshot_data { // -- data_ownership begins -- SnapshotData::DataOwnership::kNotOwned, // -- data_ownership ends -- @@ -1036,7 +1036,6 @@ static const int v8_snapshot_blob_size = )" }; const SnapshotData* SnapshotBuilder::GetEmbeddedSnapshotData() { - Mutex::ScopedLock lock(snapshot_data_mutex_); return &snapshot_data; } } // namespace node @@ -1053,8 +1052,6 @@ static void ResetContextSettingsBeforeSnapshot(Local context) { context->AllowCodeGenerationFromStrings(true); } -Mutex SnapshotBuilder::snapshot_data_mutex_; - const std::vector& SnapshotBuilder::CollectExternalReferences() { static auto registry = std::make_unique(); return registry->external_references();