Skip to content

Commit 97a0443

Browse files
RafaelGSSrichardlau
authored andcommittedFeb 14, 2023
build: build ICU with ICU_NO_USER_DATA_OVERRIDE
CVE-ID: CVE-2023-23920 Backport-PR-URL: nodejs-private/node-private#377 PR-URL: nodejs-private/node-private#374 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 9e62215 commit 97a0443

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎configure.py

+3
Original file line numberDiff line numberDiff line change
@@ -1487,6 +1487,9 @@ def icu_download(path):
14871487
# always set icu_small, node.gyp depends on it being defined.
14881488
o['variables']['icu_small'] = b(False)
14891489

1490+
# prevent data override
1491+
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
1492+
14901493
with_intl = options.with_intl
14911494
with_icu_source = options.with_icu_source
14921495
have_icu_path = bool(options.with_icu_path)

0 commit comments

Comments
 (0)
Please sign in to comment.