From 99a648738c06ecdb48db712cd5e3e5500ef43cdc Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Tue, 21 Jul 2020 08:14:45 +0530 Subject: [PATCH] doc: onboarding process extras Callout some practices explicitly, so that the process is followed in a similar manner PR-URL: https://github.com/nodejs/node/pull/34455 Reviewed-By: Rich Trott Reviewed-By: Anna Henningsen Reviewed-By: Andrey Pechkurov --- onboarding.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/onboarding.md b/onboarding.md index 31b8353ef41ec5..8ec268570e8a66 100644 --- a/onboarding.md +++ b/onboarding.md @@ -210,6 +210,9 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Use the `node-test-pull-request` CI task. * After two Collaborator approvals for the change and two Collaborator approvals for fast-tracking, land the PR. +* Leave a comment in the PR: `Please 👍 this comment to approve fast-tracking`. +* If there are not enough approvals within a reasonable time, consider the + single approval of the onboarding TSC member sufficient, and land the PR. * Be sure to add the `PR-URL: ` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing