From 99d1f6fea49e92bc3b3993d1f74ca9a8772c5d02 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 26 Nov 2019 15:48:26 -0800
Subject: [PATCH] test: move test-https-server-consumed-timeout to parallel

Change the test to be robust in slow environments and move to parallel.
The previous version of the test failed for me in parallel with just two
or four simultaneous versions running. This version passes 96
simultaneous versions running, but still fails as designed if the
request writes fail to prevent the request timeout from occurring.

PR-URL: https://github.com/nodejs/node/pull/30677
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 .../test-http-server-consumed-timeout.js      | 86 +++++++++++++++++++
 .../test-http-server-consumed-timeout.js      | 52 -----------
 2 files changed, 86 insertions(+), 52 deletions(-)
 create mode 100644 test/parallel/test-http-server-consumed-timeout.js
 delete mode 100644 test/sequential/test-http-server-consumed-timeout.js

diff --git a/test/parallel/test-http-server-consumed-timeout.js b/test/parallel/test-http-server-consumed-timeout.js
new file mode 100644
index 00000000000000..865169ca010375
--- /dev/null
+++ b/test/parallel/test-http-server-consumed-timeout.js
@@ -0,0 +1,86 @@
+'use strict';
+
+const common = require('../common');
+
+const assert = require('assert');
+const http = require('http');
+
+const durationBetweenIntervals = [];
+let timeoutTooShort = false;
+const TIMEOUT = common.platformTimeout(200);
+const INTERVAL = Math.floor(TIMEOUT / 8);
+
+runTest(TIMEOUT);
+
+function runTest(timeoutDuration) {
+  let intervalWasInvoked = false;
+  let newTimeoutDuration = 0;
+  const closeCallback = (err) => {
+    assert.ifError(err);
+    if (newTimeoutDuration) {
+      runTest(newTimeoutDuration);
+    }
+  };
+
+  const server = http.createServer((req, res) => {
+    server.close(common.mustCall(closeCallback));
+
+    res.writeHead(200);
+    res.flushHeaders();
+
+    req.setTimeout(timeoutDuration, () => {
+      if (!intervalWasInvoked) {
+        // Interval wasn't invoked, probably because the machine is busy with
+        // other things. Try again with a longer timeout.
+        newTimeoutDuration = timeoutDuration * 2;
+        console.error('The interval was not invoked.');
+        console.error(`Trying w/ timeout of ${newTimeoutDuration}.`);
+        return;
+      }
+
+      if (timeoutTooShort) {
+        intervalWasInvoked = false;
+        timeoutTooShort = false;
+        newTimeoutDuration =
+          Math.max(...durationBetweenIntervals, timeoutDuration) * 2;
+        console.error(`Time between intervals: ${durationBetweenIntervals}`);
+        console.error(`Trying w/ timeout of ${newTimeoutDuration}`);
+        return;
+      }
+
+      assert.fail('Request timeout should not fire');
+    });
+
+    req.resume();
+    req.once('end', () => {
+      res.end();
+    });
+  });
+
+  server.listen(0, common.mustCall(() => {
+    const req = http.request({
+      port: server.address().port,
+      method: 'POST'
+    }, () => {
+      let lastIntervalTimestamp = Date.now();
+      const interval = setInterval(() => {
+        const lastDuration = Date.now() - lastIntervalTimestamp;
+        durationBetweenIntervals.push(lastDuration);
+        lastIntervalTimestamp = Date.now();
+        if (lastDuration > timeoutDuration / 2) {
+          // The interval is supposed to be about 1/8 of the timeout duration.
+          // If it's running so infrequently that it's greater than 1/2 the
+          // timeout duration, then run the test again with a longer timeout.
+          timeoutTooShort = true;
+        }
+        intervalWasInvoked = true;
+        req.write('a');
+      }, INTERVAL);
+      setTimeout(() => {
+        clearInterval(interval);
+        req.end();
+      }, timeoutDuration);
+    });
+    req.write('.');
+  }));
+}
diff --git a/test/sequential/test-http-server-consumed-timeout.js b/test/sequential/test-http-server-consumed-timeout.js
deleted file mode 100644
index eb8de276b8ee53..00000000000000
--- a/test/sequential/test-http-server-consumed-timeout.js
+++ /dev/null
@@ -1,52 +0,0 @@
-'use strict';
-
-const common = require('../common');
-
-const assert = require('assert');
-const http = require('http');
-
-let intervalWasInvoked = false;
-const TIMEOUT = common.platformTimeout(50);
-
-runTest(TIMEOUT);
-
-function runTest(timeoutDuration) {
-  const server = http.createServer((req, res) => {
-    server.close();
-
-    res.writeHead(200);
-    res.flushHeaders();
-
-    req.setTimeout(timeoutDuration, () => {
-      if (!intervalWasInvoked) {
-        // Interval wasn't invoked, probably because the machine is busy with
-        // other things. Try again with a longer timeout.
-        console.error(`Retrying with timeout of ${timeoutDuration * 2}.`);
-        return setImmediate(() => { runTest(timeoutDuration * 2); });
-      }
-      assert.fail('Request timeout should not fire');
-    });
-
-    req.resume();
-    req.once('end', () => {
-      res.end();
-    });
-  });
-
-  server.listen(0, common.mustCall(() => {
-    const req = http.request({
-      port: server.address().port,
-      method: 'POST'
-    }, () => {
-      const interval = setInterval(() => {
-        intervalWasInvoked = true;
-        req.write('a');
-      }, 25);
-      setTimeout(() => {
-        clearInterval(interval);
-        req.end();
-      }, timeoutDuration);
-    });
-    req.write('.');
-  }));
-}