From 9fbcb619e1a7459498bea59cc2912e459fe3214f Mon Sep 17 00:00:00 2001
From: Sergey Petushkov <petushkov.sergey@gmail.com>
Date: Thu, 30 Jun 2022 12:18:02 +0200
Subject: [PATCH] process: make process.config read only

---
 doc/api/deprecations.md              | 15 ------
 doc/api/process.md                   | 20 ++++----
 lib/internal/bootstrap/node.js       | 70 ++--------------------------
 test/parallel/test-process-config.js | 10 ++++
 4 files changed, 22 insertions(+), 93 deletions(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 9dd2f7628d84b0..c5c79ff884fff1 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -2885,21 +2885,6 @@ Type: Documentation-only.
 
 Prefer [`message.socket`][] over [`message.connection`][].
 
-### DEP0150: Changing the value of `process.config`
-
-<!-- YAML
-changes:
-  - version: v16.0.0
-    pr-url: https://github.com/nodejs/node/pull/36902
-    description: Runtime deprecation.
--->
-
-Type: Runtime
-
-The `process.config` property provides access to Node.js compile-time settings.
-However, the property is mutable and therefore subject to tampering. The ability
-to change the value will be removed in a future version of Node.js.
-
 ### DEP0151: Main index lookup and extension searching
 
 <!-- YAML
diff --git a/doc/api/process.md b/doc/api/process.md
index ecd53469ca4221..3e2315fedeb846 100644
--- a/doc/api/process.md
+++ b/doc/api/process.md
@@ -1041,6 +1041,10 @@ This feature is not available in [`Worker`][] threads.
 <!-- YAML
 added: v0.7.7
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/43627
+    description: The object returned by `process.config` is read-only. Modifying
+                 it in strict mode will throw an error.
   - version: v16.0.0
     pr-url: https://github.com/nodejs/node/pull/36902
     description: Modifying process.config has been deprecated.
@@ -1048,10 +1052,10 @@ changes:
 
 * {Object}
 
-The `process.config` property returns an `Object` containing the JavaScript
-representation of the configure options used to compile the current Node.js
-executable. This is the same as the `config.gypi` file that was produced when
-running the `./configure` script.
+The `process.config` property returns a read-only `Object` containing the
+JavaScript representation of the configure options used to compile the current
+Node.js executable. This is the same as the `config.gypi` file that was produced
+when running the `./configure` script.
 
 An example of the possible output looks like:
 
@@ -1085,14 +1089,6 @@ An example of the possible output looks like:
 }
 ```
 
-The `process.config` property is **not** read-only and there are existing
-modules in the ecosystem that are known to extend, modify, or entirely replace
-the value of `process.config`.
-
-Modifying the `process.config` property, or any child-property of the
-`process.config` object has been deprecated. The `process.config` will be made
-read-only in a future release.
-
 ## `process.connected`
 
 <!-- YAML
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index 0f72e3e67af306..b1ee94e7ba3ad9 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -46,10 +46,8 @@ const {
   JSONParse,
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
-  ObjectPreventExtensions,
   ObjectSetPrototypeOf,
-  ReflectGet,
-  ReflectSet,
+  ObjectFreeze,
   SymbolToStringTag,
   globalThis,
 } = primordials;
@@ -72,75 +70,15 @@ process._exiting = false;
 // process.config is serialized config.gypi
 const nativeModule = internalBinding('native_module');
 
-// TODO(@jasnell): Once this has gone through one full major
-// release cycle, remove the Proxy and setter and update the
-// getter to either return a read-only object or always return
-// a freshly parsed version of nativeModule.config.
-
-const deprecationHandler = {
-  warned: false,
-  message: 'Setting process.config is deprecated. ' +
-           'In the future the property will be read-only.',
-  code: 'DEP0150',
-  maybeWarn() {
-    if (!this.warned) {
-      process.emitWarning(this.message, {
-        type: 'DeprecationWarning',
-        code: this.code
-      });
-      this.warned = true;
-    }
-  },
-
-  defineProperty(target, key, descriptor) {
-    this.maybeWarn();
-    return ObjectDefineProperty(target, key, descriptor);
-  },
-
-  deleteProperty(target, key) {
-    this.maybeWarn();
-    delete target[key];
-  },
-
-  preventExtensions(target) {
-    this.maybeWarn();
-    return ObjectPreventExtensions(target);
-  },
-
-  set(target, key, value) {
-    this.maybeWarn();
-    return ReflectSet(target, key, value);
-  },
-
-  get(target, key, receiver) {
-    const val = ReflectGet(target, key, receiver);
-    if (val != null && typeof val === 'object') {
-      // eslint-disable-next-line node-core/prefer-primordials
-      return new Proxy(val, deprecationHandler);
-    }
-    return val;
-  },
-
-  setPrototypeOf(target, proto) {
-    this.maybeWarn();
-    return ObjectSetPrototypeOf(target, proto);
-  }
-};
-
-// eslint-disable-next-line node-core/prefer-primordials
-let processConfig = new Proxy(
-  JSONParse(nativeModule.config),
-  deprecationHandler);
+const processConfig = JSONParse(nativeModule.config, (_key, value) => {
+  return ObjectFreeze(value);
+});
 
 ObjectDefineProperty(process, 'config', {
   __proto__: null,
   enumerable: true,
   configurable: true,
   get() { return processConfig; },
-  set(value) {
-    deprecationHandler.maybeWarn();
-    processConfig = value;
-  }
 });
 
 require('internal/worker/js_transferable').setup();
diff --git a/test/parallel/test-process-config.js b/test/parallel/test-process-config.js
index a48e107d4c22a3..52b5ae6a031ec0 100644
--- a/test/parallel/test-process-config.js
+++ b/test/parallel/test-process-config.js
@@ -36,6 +36,16 @@ assert(Object.hasOwn(process, 'config'));
 // Ensure that `process.config` is an Object.
 assert.strictEqual(Object(process.config), process.config);
 
+// Ensure that you can't change config values
+try {
+  process.config.variables = 42;
+} catch (e) {
+  assert.strictEqual(
+    e.message,
+    "Cannot assign to read only property 'variables' of object '#<Object>'"
+  );
+}
+
 const configPath = path.resolve(__dirname, '..', '..', 'config.gypi');
 
 if (!fs.existsSync(configPath)) {