Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
build: remove --build-v8-with-gn configure option
This option is now outdated and not used any longer.

PR-URL: #27576
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
hashseed authored and gengjiawen committed Sep 23, 2020
1 parent 3b10f7f commit a117887
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions configure.py
Expand Up @@ -40,10 +40,6 @@
import getnapibuildversion
from gyp_node import run_gyp

# imports in deps/v8/tools/node
sys.path.insert(0, os.path.join('deps', 'v8', 'tools', 'node'))
from fetch_deps import FetchDeps

# parse our options
parser = optparse.OptionParser()

Expand Down Expand Up @@ -679,12 +675,6 @@
help='do not use V8 includes from the bundled deps folder. ' +
'(This mode is not officially supported for regular applications)')

parser.add_option('--build-v8-with-gn',
action='store_true',
dest='build_v8_with_gn',
default=False,
help='build V8 using GN instead of gyp')

parser.add_option('--verbose',
action='store_true',
dest='verbose',
Expand Down Expand Up @@ -1347,14 +1337,6 @@ def configure_v8(o):
o['variables']['test_isolation_mode'] = 'noop' # Needed by d8.gyp.
if options.without_bundled_v8 and options.enable_d8:
raise Exception('--enable-d8 is incompatible with --without-bundled-v8.')
if options.without_bundled_v8 and options.build_v8_with_gn:
raise Exception(
'--build-v8-with-gn is incompatible with --without-bundled-v8.')
if options.build_v8_with_gn:
v8_path = os.path.join('deps', 'v8')
print('Fetching dependencies to build V8 with GN')
options.build_v8_with_gn = FetchDeps(v8_path)
o['variables']['build_v8_with_gn'] = b(options.build_v8_with_gn)


def configure_openssl(o):
Expand Down

0 comments on commit a117887

Please sign in to comment.