From a11788736a9eb17152f06fe28643ac2c270f4024 Mon Sep 17 00:00:00 2001 From: Yang Guo Date: Mon, 6 May 2019 07:57:45 +0200 Subject: [PATCH] build: remove --build-v8-with-gn configure option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This option is now outdated and not used any longer. PR-URL: https://github.com/nodejs/node/pull/27576 Reviewed-By: Michaël Zasso Reviewed-By: Rich Trott Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Jiawen Geng --- configure.py | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/configure.py b/configure.py index 5134892cb5234a..2e253aba84dafe 100755 --- a/configure.py +++ b/configure.py @@ -40,10 +40,6 @@ import getnapibuildversion from gyp_node import run_gyp -# imports in deps/v8/tools/node -sys.path.insert(0, os.path.join('deps', 'v8', 'tools', 'node')) -from fetch_deps import FetchDeps - # parse our options parser = optparse.OptionParser() @@ -679,12 +675,6 @@ help='do not use V8 includes from the bundled deps folder. ' + '(This mode is not officially supported for regular applications)') -parser.add_option('--build-v8-with-gn', - action='store_true', - dest='build_v8_with_gn', - default=False, - help='build V8 using GN instead of gyp') - parser.add_option('--verbose', action='store_true', dest='verbose', @@ -1347,14 +1337,6 @@ def configure_v8(o): o['variables']['test_isolation_mode'] = 'noop' # Needed by d8.gyp. if options.without_bundled_v8 and options.enable_d8: raise Exception('--enable-d8 is incompatible with --without-bundled-v8.') - if options.without_bundled_v8 and options.build_v8_with_gn: - raise Exception( - '--build-v8-with-gn is incompatible with --without-bundled-v8.') - if options.build_v8_with_gn: - v8_path = os.path.join('deps', 'v8') - print('Fetching dependencies to build V8 with GN') - options.build_v8_with_gn = FetchDeps(v8_path) - o['variables']['build_v8_with_gn'] = b(options.build_v8_with_gn) def configure_openssl(o):