Skip to content

Commit

Permalink
repl: remove deprecated repl.parseREPLKeyword() function
Browse files Browse the repository at this point in the history
This removes the deprecated REPLServer.parseREPLKeyword function. It
is deprecated for a long time and should not provide any benefit to
users. To improve the maintainability of the REPL module, it's now
removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
BridgeAR committed May 23, 2020
1 parent 4ace010 commit a1bcad8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
Expand Up @@ -1564,12 +1564,15 @@ The `REPLServer.bufferedCommand` property was deprecated in favor of
### DEP0075: `REPLServer.parseREPLKeyword()`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33286
description: End-of-Life.
- version: v9.0.0
pr-url: https://github.com/nodejs/node/pull/14223
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

`REPLServer.parseREPLKeyword()` was removed from userland visibility.

Expand Down
5 changes: 0 additions & 5 deletions lib/repl.js
Expand Up @@ -679,11 +679,6 @@ function REPLServer(prompt,
return false;
}

self.parseREPLKeyword = deprecate(
_parseREPLKeyword,
'REPLServer.parseREPLKeyword() is deprecated',
'DEP0075');

self.on('close', function emitExit() {
if (paused) {
pausedBuffer.push(['close']);
Expand Down
16 changes: 0 additions & 16 deletions test/parallel/test-repl-deprecations.js

This file was deleted.

0 comments on commit a1bcad8

Please sign in to comment.