Skip to content

Commit

Permalink
build: speed up source tarball creation
Browse files Browse the repository at this point in the history
Avoid building the node binary when building the source tarball. We
need a node binary to build the docs, but it doesn't have to be one
we build from scratch and can reuse any available node binary.

Skip building the xz compressed tarball in the build-tarball workflow
as we only use the gzip compressed tarball in the subsequent build
jobs.

PR-URL: #34508
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
  • Loading branch information
richardlau authored and MylesBorins committed Jul 27, 2020
1 parent f7600d5 commit a4806e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-tarball.yml
Expand Up @@ -26,8 +26,8 @@ jobs:
run: |
export DISTTYPE=nightly
export DATESTRING=`date "+%Y-%m-%d"`
export COMMIT=xxxx
./configure && make tar -j8
export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
./configure && make tar -j8 SKIP_XZ=1
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -1034,7 +1034,7 @@ pkg-upload: pkg
scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"

$(TARBALL): release-only $(NODE_EXE) doc
$(TARBALL): release-only doc-only
git checkout-index -a -f --prefix=$(TARNAME)/
mkdir -p $(TARNAME)/doc/api
cp doc/node.1 $(TARNAME)/doc/node.1
Expand Down

0 comments on commit a4806e2

Please sign in to comment.