From a4806e2d12982c80d2aff7245b3a316c560f7920 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Fri, 24 Jul 2020 12:46:13 -0400 Subject: [PATCH] build: speed up source tarball creation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Avoid building the node binary when building the source tarball. We need a node binary to build the docs, but it doesn't have to be one we build from scratch and can reuse any available node binary. Skip building the xz compressed tarball in the build-tarball workflow as we only use the gzip compressed tarball in the subsequent build jobs. PR-URL: https://github.com/nodejs/node/pull/34508 Reviewed-By: Anna Henningsen Reviewed-By: Michaël Zasso Reviewed-By: Zeyu Yang --- .github/workflows/build-tarball.yml | 4 ++-- Makefile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-tarball.yml b/.github/workflows/build-tarball.yml index c1d3f30408aace..699efb39d17e35 100644 --- a/.github/workflows/build-tarball.yml +++ b/.github/workflows/build-tarball.yml @@ -26,8 +26,8 @@ jobs: run: | export DISTTYPE=nightly export DATESTRING=`date "+%Y-%m-%d"` - export COMMIT=xxxx - ./configure && make tar -j8 + export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA") + ./configure && make tar -j8 SKIP_XZ=1 mkdir tarballs mv *.tar.gz tarballs - name: Upload tarball artifact diff --git a/Makefile b/Makefile index 4391499052a449..58e7d4de4771e4 100644 --- a/Makefile +++ b/Makefile @@ -1034,7 +1034,7 @@ pkg-upload: pkg scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done" -$(TARBALL): release-only $(NODE_EXE) doc +$(TARBALL): release-only doc-only git checkout-index -a -f --prefix=$(TARNAME)/ mkdir -p $(TARNAME)/doc/api cp doc/node.1 $(TARNAME)/doc/node.1