url: use ada::url_aggregator for parsing urls

PR-URL: #47339 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Apr 13, 2023 · a4895df · a4895df
1 parent 88387cc
commit a4895df
Show file tree

Hide file tree

Showing 9 changed files with 473 additions and 258 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
diff --git a/lib/url.js b/lib/url.js
@@ -58,9 +58,7 @@ const {
   urlToHttpOptions,
 } = require('internal/url');
 
-const {
-  formatUrl,
-} = internalBinding('url');
+const bindingUrl = internalBinding('url');
 
 const { getOptionValue } = require('internal/options');
 
@@ -635,7 +633,7 @@ function urlFormat(urlObject, options) {
       }
     }
 
-    return formatUrl(urlObject.href, fragment, unicode, search, auth);
+    return bindingUrl.format(urlObject.href, fragment, unicode, search, auth);
   }
 
   return Url.prototype.format.call(urlObject);

diff --git a/src/base_object_types.h b/src/base_object_types.h
@@ -15,7 +15,8 @@ namespace node {
   V(v8_binding_data, v8_utils::BindingData)                                    \
   V(blob_binding_data, BlobBindingData)                                        \
   V(process_binding_data, process::BindingData)                                \
-  V(timers_binding_data, timers::BindingData)
+  V(timers_binding_data, timers::BindingData)                                  \
+  V(url_binding_data, url::BindingData)
 
 #define UNSERIALIZABLE_BINDING_TYPES(V)                                        \
   V(http2_binding_data, http2::BindingData)                                    \

diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc
@@ -18,6 +18,7 @@
 #include "node_metadata.h"
 #include "node_process.h"
 #include "node_snapshot_builder.h"
+#include "node_url.h"
 #include "node_util.h"
 #include "node_v8.h"
 #include "node_v8_platform-inl.h"