diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js index 93681ea243b08c..97bb6e5b13dca3 100644 --- a/lib/internal/modules/cjs/loader.js +++ b/lib/internal/modules/cjs/loader.js @@ -226,6 +226,8 @@ function Module(id = '', parent) { redirects = policy.manifest.getDependencyMapper(moduleURL); // TODO(rafaelgss): remove the necessity of this branch setOwnProperty(this, 'require', makeRequireFunction(this, redirects)); + // eslint-disable-next-line no-proto + setOwnProperty(this.__proto__, 'require', makeRequireFunction(this, redirects)); } this[require_private_symbol] = internalRequire; } @@ -892,7 +894,7 @@ Module._load = function(request, parent, isMain) { const module = cachedModule || new Module(filename, parent); if (isMain) { - process.mainModule = module; + setOwnProperty(process, 'mainModule', module); setOwnProperty(module.require, 'main', process.mainModule); module.id = '.'; } diff --git a/test/fixtures/policy-manifest/main-module-proto-bypass.js b/test/fixtures/policy-manifest/main-module-proto-bypass.js new file mode 100644 index 00000000000000..6111aae140ed0a --- /dev/null +++ b/test/fixtures/policy-manifest/main-module-proto-bypass.js @@ -0,0 +1 @@ +process.mainModule.__proto__.require("os") diff --git a/test/parallel/test-policy-manifest.js b/test/parallel/test-policy-manifest.js index f8bebdf4cf69f1..5dfadb3631de66 100644 --- a/test/parallel/test-policy-manifest.js +++ b/test/parallel/test-policy-manifest.js @@ -66,3 +66,18 @@ const fixtures = require('../common/fixtures.js'); assert.strictEqual(result.status, 0); } + +{ + const policyFilepath = fixtures.path('policy-manifest', 'onerror-exit.json'); + const mainModuleBypass = fixtures.path('policy-manifest', 'main-module-proto-bypass.js'); + const result = spawnSync(process.execPath, [ + '--experimental-policy', + policyFilepath, + mainModuleBypass, + ]); + + assert.notStrictEqual(result.status, 0); + const stderr = result.stderr.toString(); + assert.match(stderr, /ERR_MANIFEST_DEPENDENCY_MISSING/); + assert.match(stderr, /does not list os as a dependency specifier for conditions: require, node, node-addons/); +}