Skip to content

Commit a733f7f

Browse files
bnoordhuisRafaelGSS
authored andcommittedSep 26, 2022
Revert "build: go faster, drop -fno-omit-frame-pointer"
This reverts commit d0f73d3. The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions. PR-URL: #44566 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 5db9779 commit a733f7f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎common.gypi

+3-3
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,9 @@
212212
'cflags': [ '-qINLINE=::150:100000' ]
213213
}],
214214
['OS!="mac" and OS!="win" and OS!="zos"', {
215+
# -fno-omit-frame-pointer is necessary for the --perf_basic_prof
216+
# flag to work correctly. perf(1) gets confused about JS stack
217+
# frames otherwise, even with --call-graph dwarf.
215218
'cflags': [ '-fno-omit-frame-pointer' ],
216219
}],
217220
['OS=="linux"', {
@@ -546,9 +549,6 @@
546549
}],
547550
],
548551
}],
549-
['OS=="freebsd" and node_use_dtrace=="true"', {
550-
'libraries': [ '-lelf' ],
551-
}],
552552
['OS=="freebsd"', {
553553
'ldflags': [
554554
'-Wl,--export-dynamic',

0 commit comments

Comments
 (0)
Please sign in to comment.