From a8530bc4e06642b0cf6b602c1c04d39ed9aeca26 Mon Sep 17 00:00:00 2001 From: Masashi Hirano Date: Mon, 1 Oct 2018 02:03:47 +0900 Subject: [PATCH] test: error when empty buffer is passed to filehandle.read() Added tests to occur error when empty buffer is passed to filehandle.read() to increase coverage. PR-URL: https://github.com/nodejs/node/pull/23250 Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Trivikram Kamat --- test/parallel/test-fs-read-empty-buffer.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/parallel/test-fs-read-empty-buffer.js b/test/parallel/test-fs-read-empty-buffer.js index 34e418eac656bf..2f44b9a1843a6b 100644 --- a/test/parallel/test-fs-read-empty-buffer.js +++ b/test/parallel/test-fs-read-empty-buffer.js @@ -6,6 +6,7 @@ const assert = require('assert'); const fs = require('fs'); const filepath = fixtures.path('x.txt'); const fd = fs.openSync(filepath, 'r'); +const fsPromises = fs.promises; const buffer = new Uint8Array(); @@ -26,3 +27,15 @@ assert.throws( 'Received Uint8Array []' } ); + +(async () => { + const filehandle = await fsPromises.open(filepath, 'r'); + assert.rejects( + () => filehandle.read(buffer, 0, 1, 0), + { + code: 'ERR_INVALID_ARG_VALUE', + message: 'The argument \'buffer\' is empty and cannot be written. ' + + 'Received Uint8Array []' + } + ); +})();