From a910320ef3aa379ac8c64d8b166b165c53bb1578 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 7 Mar 2018 20:08:17 -0800 Subject: [PATCH] test: do not check text for engine-generated error In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. PR-URL: https://github.com/nodejs/node/pull/19215 Reviewed-By: Daniel Bevenius Reviewed-By: Colin Ihrig Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- test/parallel/test-tls-wrap-event-emmiter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-tls-wrap-event-emmiter.js b/test/parallel/test-tls-wrap-event-emmiter.js index b6ae9e2d5a7e99..871e6c9ae6834c 100644 --- a/test/parallel/test-tls-wrap-event-emmiter.js +++ b/test/parallel/test-tls-wrap-event-emmiter.js @@ -15,5 +15,5 @@ const TlsSocket = require('tls').TLSSocket; const EventEmitter = require('events').EventEmitter; assert.throws( () => { new TlsSocket(new EventEmitter()); }, - /^TypeError: (.+) is not a function$/ + TypeError );