Skip to content

Commit a9a606f

Browse files
TrottMylesBorins
authored andcommittedNov 16, 2020
lib: use full URL to GitHub issues in comments
Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: #34686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 68c5ee4 commit a9a606f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed
 

‎lib/internal/stream_base_commons.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,8 @@ function onStreamRead(arrayBuffer) {
204204
}
205205

206206
if (nread !== UV_EOF) {
207-
// #34375 CallJSOnreadMethod expects the return value to be a buffer.
207+
// CallJSOnreadMethod expects the return value to be a buffer.
208+
// Ref: https://github.com/nodejs/node/pull/34375
208209
stream.destroy(errnoException(nread, 'read'));
209210
return;
210211
}
@@ -224,7 +225,8 @@ function onStreamRead(arrayBuffer) {
224225
if (handle.readStop) {
225226
const err = handle.readStop();
226227
if (err) {
227-
// #34375 CallJSOnreadMethod expects the return value to be a buffer.
228+
// CallJSOnreadMethod expects the return value to be a buffer.
229+
// Ref: https://github.com/nodejs/node/pull/34375
228230
stream.destroy(errnoException(err, 'read'));
229231
return;
230232
}

0 commit comments

Comments
 (0)
Please sign in to comment.