Navigation Menu

Skip to content

Commit

Permalink
lib: use full URL to GitHub issues in comments
Browse files Browse the repository at this point in the history
Don't assume the reader of the code will know where to find the issue
tracker. Provide the full URL. This is especially important if the
issue tracker should move again.

PR-URL: #34686
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Nov 16, 2020
1 parent 68c5ee4 commit a9a606f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/internal/stream_base_commons.js
Expand Up @@ -204,7 +204,8 @@ function onStreamRead(arrayBuffer) {
}

if (nread !== UV_EOF) {
// #34375 CallJSOnreadMethod expects the return value to be a buffer.
// CallJSOnreadMethod expects the return value to be a buffer.
// Ref: https://github.com/nodejs/node/pull/34375
stream.destroy(errnoException(nread, 'read'));
return;
}
Expand All @@ -224,7 +225,8 @@ function onStreamRead(arrayBuffer) {
if (handle.readStop) {
const err = handle.readStop();
if (err) {
// #34375 CallJSOnreadMethod expects the return value to be a buffer.
// CallJSOnreadMethod expects the return value to be a buffer.
// Ref: https://github.com/nodejs/node/pull/34375
stream.destroy(errnoException(err, 'read'));
return;
}
Expand Down

0 comments on commit a9a606f

Please sign in to comment.