From a9a606f06b2228d0c7d936f32e57ab346a5515f5 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 8 Aug 2020 16:39:05 -0700 Subject: [PATCH] lib: use full URL to GitHub issues in comments Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: https://github.com/nodejs/node/pull/34686 Reviewed-By: Anna Henningsen Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Ruben Bridgewater Reviewed-By: Mary Marchini Reviewed-By: Denys Otrishko Reviewed-By: James M Snell --- lib/internal/stream_base_commons.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js index 233741285d2c72..4f48c2be794626 100644 --- a/lib/internal/stream_base_commons.js +++ b/lib/internal/stream_base_commons.js @@ -204,7 +204,8 @@ function onStreamRead(arrayBuffer) { } if (nread !== UV_EOF) { - // #34375 CallJSOnreadMethod expects the return value to be a buffer. + // CallJSOnreadMethod expects the return value to be a buffer. + // Ref: https://github.com/nodejs/node/pull/34375 stream.destroy(errnoException(nread, 'read')); return; } @@ -224,7 +225,8 @@ function onStreamRead(arrayBuffer) { if (handle.readStop) { const err = handle.readStop(); if (err) { - // #34375 CallJSOnreadMethod expects the return value to be a buffer. + // CallJSOnreadMethod expects the return value to be a buffer. + // Ref: https://github.com/nodejs/node/pull/34375 stream.destroy(errnoException(err, 'read')); return; }