From ab78d4df34a7698c45fca0b81300fd02fc4add7b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
Date: Tue, 22 Oct 2019 15:28:34 +0200
Subject: [PATCH] src: fix crash with SyntheticModule#setExport

Use the new non-deprecated V8 API for that.

PR-URL: https://github.com/nodejs/node/pull/30062
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 src/module_wrap.cc                        | 2 +-
 test/parallel/test-vm-module-synthetic.js | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/module_wrap.cc b/src/module_wrap.cc
index 46210520fcb990..4c4a1ce863849e 100644
--- a/src/module_wrap.cc
+++ b/src/module_wrap.cc
@@ -1500,7 +1500,7 @@ void ModuleWrap::SetSyntheticExport(
   Local<Value> export_value = args[1];
 
   Local<Module> module = obj->module_.Get(isolate);
-  module->SetSyntheticModuleExport(export_name, export_value);
+  USE(module->SetSyntheticModuleExport(isolate, export_name, export_value));
 }
 
 void ModuleWrap::Initialize(Local<Object> target,
diff --git a/test/parallel/test-vm-module-synthetic.js b/test/parallel/test-vm-module-synthetic.js
index 71df9bd2633daf..83a78f2f3f5ba2 100644
--- a/test/parallel/test-vm-module-synthetic.js
+++ b/test/parallel/test-vm-module-synthetic.js
@@ -36,8 +36,6 @@ const assert = require('assert');
     });
   }
 
-  // https://bugs.chromium.org/p/v8/issues/detail?id=9828
-  /*
   {
     const s = new SyntheticModule([], () => {});
     await s.link(() => {});
@@ -47,7 +45,6 @@ const assert = require('assert');
       name: 'ReferenceError',
     });
   }
-  */
 
   {
     const s = new SyntheticModule([], () => {});