From abe2eb9fc097bfd8238da4dd4b91a6263fe81371 Mon Sep 17 00:00:00 2001 From: MrJithil Date: Sat, 29 Jan 2022 11:20:26 +0530 Subject: [PATCH] benchmark: avoid input param manipulation PR-URL: https://github.com/nodejs/node/pull/41741 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Mary Marchini Reviewed-By: James M Snell --- benchmark/assert/deepequal-object.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js index a8c539426a8156..7418e2a745ba40 100644 --- a/benchmark/assert/deepequal-object.js +++ b/benchmark/assert/deepequal-object.js @@ -24,8 +24,7 @@ function createObj(source, add = '') { } function main({ size, n, method, strict }) { - // TODO: Fix this "hack". `n` should not be manipulated. - n = Math.min(Math.ceil(n / size), 20); + const len = Math.min(Math.ceil(n / size), 20); const source = Array.apply(null, Array(size)); const actual = createObj(source); @@ -39,8 +38,8 @@ function main({ size, n, method, strict }) { const value2 = method.includes('not') ? expectedWrong : expected; bench.start(); - for (let i = 0; i < n; ++i) { + for (let i = 0; i < len; ++i) { fn(actual, value2); } - bench.end(n); + bench.end(len); }