Skip to content

Commit

Permalink
src: remove unused CancelPendingDelayedTasks
Browse files Browse the repository at this point in the history
PR-URL: #32859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  • Loading branch information
addaleax committed Apr 24, 2020
1 parent a6c57cc commit ac37146
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions src/node.h
Expand Up @@ -295,11 +295,6 @@ class NODE_EXTERN MultiIsolatePlatform : public v8::Platform {
virtual bool FlushForegroundTasks(v8::Isolate* isolate) = 0;
virtual void DrainTasks(v8::Isolate* isolate) = 0;

// TODO(addaleax): Remove this, it is unnecessary.
// This would currently be called before `UnregisterIsolate()` but will be
// folded into it in the future.
virtual void CancelPendingDelayedTasks(v8::Isolate* isolate);

// This needs to be called between the calls to `Isolate::Allocate()` and
// `Isolate::Initialize()`, so that initialization can already start
// using the platform.
Expand Down
2 changes: 0 additions & 2 deletions src/node_platform.cc
Expand Up @@ -609,6 +609,4 @@ std::queue<std::unique_ptr<T>> TaskQueue<T>::PopAll() {
return result;
}

void MultiIsolatePlatform::CancelPendingDelayedTasks(Isolate* isolate) {}

} // namespace node

0 comments on commit ac37146

Please sign in to comment.