Skip to content

Commit ad06168

Browse files
deokjinkimdanielleadams
authored andcommittedApr 11, 2023
doc: use number which is bigger than 1024 as port in http2
With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2. PR-URL: #46938 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 77f5b69 commit ad06168

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
 

‎doc/api/http2.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ server.on('stream', (stream, headers) => {
354354
stream.end('<h1>Hello World</h1>');
355355
});
356356

357-
server.listen(80);
357+
server.listen(8000);
358358
```
359359

360360
Even though HTTP/2 streams and network sockets are not in a 1:1 correspondence,
@@ -2518,7 +2518,7 @@ server.on('stream', (stream, headers) => {
25182518
stream.end('<h1>Hello World</h1>');
25192519
});
25202520

2521-
server.listen(80);
2521+
server.listen(8000);
25222522
```
25232523

25242524
### `http2.createSecureServer(options[, onRequestHandler])`
@@ -2659,7 +2659,7 @@ server.on('stream', (stream, headers) => {
26592659
stream.end('<h1>Hello World</h1>');
26602660
});
26612661

2662-
server.listen(80);
2662+
server.listen(8443);
26632663
```
26642664

26652665
### `http2.connect(authority[, options][, listener])`

0 commit comments

Comments
 (0)
Please sign in to comment.