Skip to content

Commit

Permalink
lib: add URI handling functions to primordials
Browse files Browse the repository at this point in the history
PR-URL: #37394
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
aduh95 authored and targos committed Jun 11, 2021
1 parent a4dd50f commit af39df6
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/.eslintrc.yaml
Expand Up @@ -38,6 +38,10 @@ rules:
- name: Boolean
- name: DataView
- name: Date
- name: decodeURI
- name: decodeURIComponent
- name: encodeURI
- name: encodeURIComponent
- name: Error
ignore:
- prepareStackTrace
Expand Down
4 changes: 4 additions & 0 deletions lib/internal/freeze_intrinsics.js
Expand Up @@ -107,6 +107,10 @@ const {
WeakMapPrototype,
WeakSet,
WeakSetPrototype,
decodeURI,
decodeURIComponent,
encodeURI,
encodeURIComponent,
} = primordials;

module.exports = function() {
Expand Down
10 changes: 10 additions & 0 deletions lib/internal/per_context/primordials.js
Expand Up @@ -173,6 +173,16 @@ primordials.SafeWeakSet = makeSafe(
}
);

// Create copies of URI handling functions
[
decodeURI,
decodeURIComponent,
encodeURI,
encodeURIComponent,
].forEach((fn) => {
primordials[fn.name] = fn;
});

// Create copies of the namespace objects
[
'JSON',
Expand Down
1 change: 1 addition & 0 deletions lib/internal/url.js
Expand Up @@ -30,6 +30,7 @@ const {
Symbol,
SymbolIterator,
SymbolToStringTag,
decodeURIComponent,
} = primordials;

const { inspect } = require('internal/util/inspect');
Expand Down
1 change: 1 addition & 0 deletions lib/querystring.js
Expand Up @@ -34,6 +34,7 @@ const {
String,
StringPrototypeCharCodeAt,
StringPrototypeSlice,
decodeURIComponent,
} = primordials;

const { Buffer } = require('buffer');
Expand Down
1 change: 1 addition & 0 deletions lib/url.js
Expand Up @@ -27,6 +27,7 @@ const {
ObjectKeys,
SafeSet,
StringPrototypeCharCodeAt,
decodeURIComponent,
} = primordials;

const { toASCII } = require('internal/idna');
Expand Down

0 comments on commit af39df6

Please sign in to comment.