From b297dd5393628cafa204abeec374a641976b7d06 Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Mon, 12 Dec 2022 12:42:44 +0100
Subject: [PATCH] test: remove flaky parallel/test-process-wrap test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It's an old test (added when switching from libev to libuv) that tests
implementation details of the internal process_wrap bindings. That kind
of thing doesn't need testing in this day and age, and since the test is
flaky, simply remove it instead of sinking time in fixing it up.

Fixes: https://github.com/nodejs/node/issues/45805
PR-URL: https://github.com/nodejs/node/pull/45806
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
---
 test/parallel/test-process-wrap.js | 86 ------------------------------
 1 file changed, 86 deletions(-)
 delete mode 100644 test/parallel/test-process-wrap.js

diff --git a/test/parallel/test-process-wrap.js b/test/parallel/test-process-wrap.js
deleted file mode 100644
index 997e3e43908010..00000000000000
--- a/test/parallel/test-process-wrap.js
+++ /dev/null
@@ -1,86 +0,0 @@
-// Flags: --expose-internals
-// Copyright Joyent, Inc. and other Node contributors.
-//
-// Permission is hereby granted, free of charge, to any person obtaining a
-// copy of this software and associated documentation files (the
-// "Software"), to deal in the Software without restriction, including
-// without limitation the rights to use, copy, modify, merge, publish,
-// distribute, sublicense, and/or sell copies of the Software, and to permit
-// persons to whom the Software is furnished to do so, subject to the
-// following conditions:
-//
-// The above copyright notice and this permission notice shall be included
-// in all copies or substantial portions of the Software.
-//
-// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
-// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
-// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
-// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
-// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-'use strict';
-require('../common');
-const assert = require('assert');
-const { internalBinding } = require('internal/test/binding');
-const Process = internalBinding('process_wrap').Process;
-const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap');
-const pipe = new Pipe(PipeConstants.SOCKET);
-const p = new Process();
-
-let processExited = false;
-let gotPipeEOF = false;
-let gotPipeData = false;
-
-p.onexit = function(exitCode, signal) {
-  console.log('exit');
-  p.close();
-  pipe.readStart();
-
-  assert.strictEqual(exitCode, 0);
-  assert.strictEqual(signal, '');
-
-  processExited = true;
-};
-
-pipe.onread = function(arrayBuffer) {
-  assert.ok(processExited);
-  if (arrayBuffer) {
-    gotPipeData = true;
-  } else {
-    gotPipeEOF = true;
-    pipe.close();
-  }
-};
-
-p.spawn({
-  file: process.execPath,
-  args: [process.execPath, '-v'],
-  stdio: [
-    { type: 'ignore' },
-    { type: 'pipe', handle: pipe },
-    { type: 'ignore' },
-  ]
-});
-
-// 'this' safety
-// https://github.com/joyent/node/issues/6690
-assert.throws(function() {
-  const notp = { spawn: p.spawn };
-  notp.spawn({
-    file: process.execPath,
-    args: [process.execPath, '-v'],
-    stdio: [
-      { type: 'ignore' },
-      { type: 'pipe', handle: pipe },
-      { type: 'ignore' },
-    ]
-  });
-}, TypeError);
-
-process.on('exit', function() {
-  assert.ok(processExited);
-  assert.ok(gotPipeEOF);
-  assert.ok(gotPipeData);
-});