Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
tools: add release host var to promotion script
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers
to provide a custom proxy host to connect to when performing the
promotion steps of a given release.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45913
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
ruyadorno authored and juanarbol committed Jan 31, 2023
1 parent 7fc7b19 commit b48e82e
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
8 changes: 8 additions & 0 deletions doc/contributing/releases.md
Expand Up @@ -827,6 +827,14 @@ or at runtime with:
$ ./tools/release.sh -i ~/.ssh/node_id_rsa
```

You can also specify a different ssh server address to connect to by defining
a `NODEJS_RELEASE_HOST` environment variable:

```console
# Substitute proxy.xyz with whatever address you intend to use
$ NODEJS_RELEASE_HOST=proxy.xyz ./tools/release.sh
```

`tools/release.sh` will perform the following actions when run:

<details>
Expand Down
4 changes: 3 additions & 1 deletion tools/release.sh
Expand Up @@ -8,7 +8,9 @@

set -e

webhost=direct.nodejs.org
[ -z "$NODEJS_RELEASE_HOST" ] && NODEJS_RELEASE_HOST=direct.nodejs.org

webhost=$NODEJS_RELEASE_HOST
webuser=dist
promotablecmd=dist-promotable
promotecmd=dist-promote
Expand Down

0 comments on commit b48e82e

Please sign in to comment.